Skip to content

Conversation

@sotagg
Copy link
Contributor

@sotagg sotagg commented Aug 23, 2025

Description

  • Replace deprecated pm.MutableData references with pm.Data
  • Fix docstring examples to use correct coords parameter

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7900.org.readthedocs.build/en/7900/

@welcome
Copy link

welcome bot commented Aug 23, 2025

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.48%. Comparing base (3a0186e) to head (849860a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7900   +/-   ##
=======================================
  Coverage   91.47%   91.48%           
=======================================
  Files         116      116           
  Lines       18947    18947           
=======================================
+ Hits        17332    17333    +1     
+ Misses       1615     1614    -1     
Files with missing lines Coverage Δ
pymc/gp/hsgp_approx.py 88.39% <ø> (ø)
pymc/sampling/forward.py 96.75% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sotagg sotagg force-pushed the doc/remove-mutabledata branch from df32146 to 624347d Compare August 25, 2025 12:03
@sotagg
Copy link
Contributor Author

sotagg commented Aug 25, 2025

@twiecki
I had to force-push this branch since it was behind main. I'm not sure what caused the last CI run to fail because it seems unrelated to my changes.

@williambdean williambdean changed the title Doc/remove mutabledata Doc/remove MutableData Oct 22, 2025
@williambdean
Copy link
Contributor

@sotagg , I've updated the branch. Let's see if it passes now

@williambdean williambdean changed the title Doc/remove MutableData doc: remove MutableData Oct 22, 2025
@ricardoV94
Copy link
Member

Seems like a test was expecting a warning?

@williambdean
Copy link
Contributor

Seems like a test was expecting a warning?

Seems unrelated

@ricardoV94
Copy link
Member

Seems like a test was expecting a warning?

Seems unrelated

Ah it is probably picking on the new PyTensor and we remove numpy warnings. Can you remove the pytest.warns?

@sotagg sotagg force-pushed the doc/remove-mutabledata branch from c4f5143 to b3dddf0 Compare October 24, 2025 14:08
@williambdean williambdean merged commit a6e6fa8 into pymc-devs:main Nov 4, 2025
26 checks passed
@welcome
Copy link

welcome bot commented Nov 4, 2025

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@williambdean
Copy link
Contributor

Thanks for the PR @sotagg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants