- 
                Notifications
    You must be signed in to change notification settings 
- Fork 31
mypy==0.991 #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            altendky
  wants to merge
  10
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
mypy_0.991
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    mypy==0.991 #202
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            10 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      4789472
              
                mypy==0.991
              
              
                altendky 5c9df5a
              
                old mypy for old python
              
              
                altendky 3588f18
              
                Update setup.py
              
              
                altendky 77ead26
              
                monkey patch mypy.stubtest._verify_final() to be a noop
              
              
                altendky 28b84b8
              
                Update setup.py
              
              
                altendky 7f86f09
              
                print when successfully monkey patched as well
              
              
                altendky 1b99db9
              
                sys.stdout.flush()
              
              
                altendky ddd513c
              
                faulthandler
              
              
                altendky 71f8111
              
                it is...  more complicated
              
              
                altendky b775ddc
              
                Merge branch 'master' into mypy_0.991
              
              
                bluebird75 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # workaround for https://github.com/python/mypy/issues/14196 | ||
|  | ||
| import faulthandler | ||
| import sys | ||
| import typing | ||
|  | ||
| import mypy.stubtest | ||
|  | ||
|  | ||
| sentinel = object | ||
|  | ||
|  | ||
| def noop_generator(*args, **kwargs) -> typing.Iterator[object]: | ||
| return | ||
| yield # make it a generator as the original is | ||
|  | ||
|  | ||
| def maybe_monkey_patch(object_: object, name: str, replacement: object) -> None: | ||
| attribute = getattr(object_, name, sentinel) | ||
| if attribute is sentinel: | ||
| print(f"{name} does not exist on {object_}, skipping monkey patching") | ||
| return | ||
|  | ||
| setattr(object_, name, replacement) | ||
| print(f"{name} on {object_} monkey patched by {replacement}") | ||
| return | ||
|  | ||
|  | ||
| def main() -> int: | ||
| maybe_monkey_patch( | ||
| object_=mypy.stubtest, | ||
| name="_verify_final", | ||
| replacement=noop_generator, | ||
| ) | ||
|  | ||
| # make sure the messages get out since we're working around a segfault here | ||
| sys.stdout.flush() | ||
| # in case we still get a segfault, try to report it | ||
| faulthandler.enable() | ||
|  | ||
| return mypy.stubtest.main() | ||
|  | ||
|  | ||
| sys.exit(main()) | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know you can do things like this. Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the
env_varlist at https://peps.python.org/pep-0508/.Though it appears this boundary may belong closer to 0.981 python/mypy@dc118e2.