Add example scripts to run pyperformance on a generic hosts #436
Conversation
| install = True | ||
|
|
||
| # Specify '-j' parameter in 'make' command | ||
| jobs = 32 |
There was a problem hiding this comment.
If I'm not misunderstanding: 10 (pool size) * 32 will be serious!
There was a problem hiding this comment.
The machine I was running the backfill has 192 cores but the latest 16 have been reserved for benchmarks. So there are really 176 cores available. I can decrease to 16 or maybe decrease the numbers of parallel jobs.
In reality this doesn't cause a problem because the compilation step with so many cores takes just a few minutes.
Anyway I'll set it less aggressive (24)
There was a problem hiding this comment.
Also bear in mind that this file is used for the daily run of pyperformance, when 192 cores will be idle :)
|
Would you like to give me a time to this weekend? |
no rush! |
|
Sorry for the delay plan to review in 24hours |
| sha = revision[0] | ||
| branch = revision[1] |
There was a problem hiding this comment.
| sha = revision[0] | |
| branch = revision[1] | |
| sha, branch = revision |
nit
| """ | ||
|
|
||
|
|
||
| def get_revisions(): |
There was a problem hiding this comment.
| def get_revisions(): | |
| def get_revisions() -> tuple[str, str]: |
| pool = Pool(8) | ||
| signal.signal(signal.SIGINT, original_sigint_handler) | ||
| try: | ||
| res = pool.map_async(run_pyperformance, get_revisions()) | ||
| # Without the timeout this blocking call ignores all signals. | ||
| res.get(86400) | ||
| except KeyboardInterrupt: | ||
| print("Caught KeyboardInterrupt, terminating workers") | ||
| pool.terminate() | ||
| else: | ||
| print("Normal termination") | ||
| pool.close() | ||
| pool.join() |
There was a problem hiding this comment.
Just a minor suggestion, why not use a simpler and more Pythonic approach like this?
| pool = Pool(8) | |
| signal.signal(signal.SIGINT, original_sigint_handler) | |
| try: | |
| res = pool.map_async(run_pyperformance, get_revisions()) | |
| # Without the timeout this blocking call ignores all signals. | |
| res.get(86400) | |
| except KeyboardInterrupt: | |
| print("Caught KeyboardInterrupt, terminating workers") | |
| pool.terminate() | |
| else: | |
| print("Normal termination") | |
| pool.close() | |
| pool.join() | |
| signal.signal(signal.SIGINT, original_sigint_handler) | |
| with Pool(8) as pool: | |
| res = pool.map_async(run_pyperformance, get_revisions()) | |
| # Without the timeout this blocking call ignores all signals. | |
| res.get(86400) |
4 participants
No description provided.