-
Notifications
You must be signed in to change notification settings - Fork 697
Arm backend: Propagate node info from quantizer to backend #15300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arm backend: Propagate node info from quantizer to backend #15300
Conversation
Use the Node meta 'custom' field to propagate information from quantizer to partitioner using a new ArmAnnotationInfo data class. This allows us to track quantized node reliably which is useful in order to track which nodes should 'fold' it's quantization parameter and which should be kept in fp when mixing integer and float in a sub-graph. Co-authored-by: Per Åstrand <per.astrand@arm.com> Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I31309d65cac50e497318eae8678880684ec77cda
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15300
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 4 Unrelated FailuresAs of commit ce3dd25 with merge base de56c81 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| node.meta[Q_ANNOTATION_KEY]._annotated = True | ||
| meta_custom = node.meta.get("custom", {}) | ||
| meta_custom[ArmAnnotationInfo.CUSTOM_META_KEY] = annotation_info | ||
| node.meta["custom"] = meta_custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@digantdesai What are your thoughts on this conceptually?
Use the Node meta 'custom' field to propagate information from quantizer to partitioner using a new ArmAnnotationInfo data class. This allows us to track quantized node reliably which is useful in order to track which nodes should 'fold' it's quantization parameter and which should be kept in fp when mixing integer and float in a sub-graph.
cc @freddan80 @per @zingo @digantdesai