Skip to content

Conversation

@gpires-meta
Copy link

Summary:
Rename Test Suites in test_sdpa_with_kv_cache to follow internal tooling conventions and make test target static listable.

Previously, some of the Test Suites in the modified test file did not satisfy the condition:

  • Test Suite's name must contain Test

This diff makes it so that the Test Suites follow the expected conventions.

Benefits

Following the conventions grants the test targets:

  • Faster test listing
  • Better dev experience in VSCode

Differential Revision: D85428922

Summary:
Rename Test Suites in `test_sdpa_with_kv_cache` to follow internal tooling conventions and make test target static listable.

Previously, some of the Test Suites in the modified test file did not satisfy the condition:
* Test Suite's name must contain `Test`

This diff makes it so that the Test Suites follow the expected conventions.

### Benefits
Following the conventions grants the test targets:
* Faster test listing
* Better dev experience in VSCode

Differential Revision: D85428922
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15375

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit 7fed498 with merge base de56c81 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link

meta-codesync bot commented Oct 24, 2025

@gpires-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85428922.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant