feat: work with env vars #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinGauk
reviewed
Nov 3, 2025
questionpy_sdk/webserver/server.py
Outdated
| requested_environment_variables = self._manifest.environment_variables or set() | ||
| if missing_environment_variables := requested_environment_variables - os.environ.keys(): | ||
| msg = f"Required environment variables not set: {missing_environment_variables}" | ||
| raise ValueError(msg) |
Contributor
There was a problem hiding this comment.
Führe hier bitte noch eine eigene Exception ein, die irgendwo abgefangen wird und nur die Nachricht ausgeben lässt. Für so einen Standard-Fehler sollten wir den Usern nicht die komplette Exception inkl. Stacktrace ausgeben lassen.
Contributor
Author
There was a problem hiding this comment.
$ questionpy-sdk run llm_teacher/
Successfully built package 'llm_teacher/'.
Error: The following environment variables are required to run the package: OPENAI_BASE_URL, OPENAI_MODEL, OPENAI_API_KEY
janbritz
force-pushed
the
feat/request-env-vars
branch
from
bb503cc to
1a8396d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242