-
Notifications
You must be signed in to change notification settings - Fork 12
adding mssql support #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the PR. As far as the data-service is concerned, I'd suggest transforming This would allow splitting loading the mssql bits only in a Dockerfile.mssql variant, and not directly in the base variant, since not all users necessarily want the proprietary mssql driver in the data-service base image. As far as other changes, you'll also need to extend the |
|
please also see qwc-services/qwc-config-generator#99 |
| from dataset_features_provider import DatasetFeaturesProvider | ||
| from dataset_features_provider_factory import create_dataset_features_provider | ||
| from attachments_service import AttachmentsService | ||
| from spatial_adapter import SpatialAdapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unused?
| from decimal import Decimal | ||
| from uuid import UUID | ||
|
|
||
| from flask import json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this file is now also unused?
making modifications to data-service to hopefully support MSSQL, not sure what else is needed on the front end to accomodate