Skip to content

Conversation

@p-schlickmann
Copy link
Contributor

@p-schlickmann p-schlickmann commented Oct 23, 2025

#663 helped me quickly identify another source of flakiness from processes_lifecycle_test.rb.

The combination of logs + GPT 5 is really powerful!

Run: https://github.com/p-schlickmann/solid_queue/actions/runs/18749897031/job/53486391931
Logs: https://github.com/p-schlickmann/solid_queue/actions/runs/18749897031/artifacts/4352196774

This test assumed that the background worker crash would leave both exit_job and pause_job in the :claimed state. In reality, this state is non-deterministic because the supervisor may detect the worker's death and fail the :claimed jobs before the assertion runs.

The test was updated to assert only the final, deterministic :failed state instead of relying on the transient :claimed state.

Another option to make it 100% deterministic would be pausing the supervisor before that check somehow, and than resume it right after. But I don't think that's a good idea.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant