Log info message with UDI instead of ID for unpublished node #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because only the UDI is saved to the database, the ID of unpublished/deleted nodes can't be retrieved (the
IPublishedContentisn't initialized) and the log is filled with meaningless warnings:MultiUrlPicker value converter skipped a link as the node has been unpublished/deleted (Id: ),Besides changing the ID to UDI, I've changed the level from warning to informational, because it's not something that actually goes wrong. The built-in
Umbraco.MultiNodeTreePicker2doesn't even log these (see https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web/PropertyEditors/ValueConverters/MultiNodeTreePickerPropertyConverter.cs). The message itself also doesn't need to repeat the property editor, because the logger name is alreadyRJP.MultiUrlPicker.Models.MultiUrls.