Skip to content

Allow custom LCP device identifiers #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2025
Merged

Allow custom LCP device identifiers #720

merged 4 commits into from
Nov 6, 2025

Conversation

@dewantawsif
Copy link
Contributor

@dewantawsif dewantawsif commented Oct 24, 2025 •
edited
Loading

Also make sure that we set generated device id only once after DeviceService has been initialized

mickael-menu
mickael-menu approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dewantawsif

@mickael-menu mickael-menu changed the title Add a LCP constructor parameter to pass a custom device id Allow custom LCP device identifiers Nov 6, 2025
@mickael-menu mickael-menu merged commit 8bf84c9 into readium:develop Nov 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickael-menu mickael-menu mickael-menu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dewantawsif @mickael-menu