Skip to content

Fix: homepage preview scroll stuck issue (#2045) #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix: homepage preview scroll stuck issue (#2045) #2063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 21 additions & 26 deletions app/src/main/java/com/lagradost/cloudstream3/ui/home/HomeFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,33 +699,28 @@ class HomeFragment : Fragment() {
}
}
} else {
// Header scrolling is only relevant to TV/Emulator

val view = recyclerView.findViewHolderForAdapterPosition(0)?.itemView
val scrollParent = binding?.homeApiHolder
val scrollParent = binding?.homeApiHolder
val firstVisibleView = recyclerView.findViewHolderForAdapterPosition(0)?.itemView

if (firstVisibleView == null) {
// Scrolled past header – hide the API provider row
scrollParent?.isVisible = false
} else {
// Smoothly re-show API provider row when scrolled back up
val rect = IntArray(2)
firstVisibleView.getLocationInWindow(rect)

// Keep the header visible and restore translation smoothly
scrollParent?.apply {
if (!isVisible) isVisible = true
translationY = rect[1].toFloat() - 60.toPx

// Ensure it's not stuck hidden due to quick focus/scroll
if (translationY > 0f) translationY = 0f
}
}
}

if (view == null) {
// The first view is not visible, so we can assume we have scrolled past it
scrollParent?.isVisible = false
} else {
// A bit weird, but this is a major limitation we are working around here
// 1. We cant have a real parent to the recyclerview as android cant layout that without lagging
// 2. We cant put the view in the recyclerview, as it should always be shown
// 3. We cant mirror the view in the recyclerview as then it causes focus issues when swaping out the mirror view
//
// This means that if we want to have a parent view to the recyclerview we are out of luck
// Instead this uses getLocationInWindow to calculate how much the view should be scrolled
// as recyclerView has no scrollY (always 0)
//
// Then it manually "scrolls" it to the correct position
//
// Hopefully getLocationInWindow acts correctly on all devices
val rect = IntArray(2)
view.getLocationInWindow(rect)
scrollParent?.isVisible = true
scrollParent?.translationY = rect[1].toFloat() - 60.toPx
}
}
super.onScrolled(recyclerView, dx, dy)
}
})
Expand Down