Add jdk toolchain #2146
Open
Add jdk toolchain #2146
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better support for building with later java versions which have deprecated compiling with Java 8 so it doesn't always give deprecation warnings. Starting with AGP 9, building with Java 17 is no longer supported, Java 8 still works for compiling, but building will require Java 21 or later so this is preparing for that. It might still be out a bit but it's probably a good thing to start preparing for it. This PR should have no affect to the current build process other than making it easier and more clear to build with more modern Java versions without loosing any legacy support or being spammed with a bunch of warnings.
Contributor
Author
|
@fire-light42 could this be merged by chance? At least in theory (though I'm pretty sure) it shouldn't affect existing behavior at all just stop warnings when building with higher Java versions then 17 ensuring we keep supporting Java 8 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better support for building with later java versions which have deprecated compiling with Java 8 so it doesn't always give deprecation warnings.
Starting with AGP 9, building with Java 17 is no longer supported, Java 8 still works for compiling, but building will require Java 21 or later so this is preparing for that. It might still be out a bit but it's probably a good thing to start preparing for it.
This PR should have no affect to the current build process other than making it easier and more clear to build with more modern Java versions without loosing any legacy support or being spammed with a bunch of warnings.