DEV: Improve code style with turning on few ESlint rules

[pawelangelow]

It's easier if you go commit by commit.

1. Turning on prettier/prettier rules - results in empty lines, adjusted imports, etc... NO business logic change here.
2. Turning on @typescript-eslint/*** results in one business logic change - redisinsight/api/src/main.ts file and the rest are cosmetics - unused variables deleted, naming, etc...

[github-actions]

Code Coverage - Integration Tests

Status	Category	Percentage	Covered / Total
🟢	Statements	81.66%	16275/19928
🟡	Branches	64.66%	7346/11360
🟡	Functions	70.64%	2284/3233
🟢	Lines	81.31%	15313/18832

[github-actions]

Code Coverage - Backend unit tests

St.❔	Category	Percentage	Covered / Total
🟢	Statements	92.33%	13870/15022
🟡	Branches	74.11%	4188/5651
🟢	Functions	85.84%	2133/2485
🟢	Lines	92.13%	13259/14391

Test suite run success

2965 tests passing in 287 suites.

Report generated by 🧪jest coverage report action from b03d096

[github-actions]

Code Coverage - Frontend unit tests

St.❔	Category	Percentage	Covered / Total
🟢	Statements	82.24%	20149/24499
🟡	Branches	67.72%	8727/12887
🟡	Functions	76.39%	5361/7018
🟢	Lines	82.65%	19727/23867

Test suite run success

5229 tests passing in 681 suites.

Report generated by 🧪jest coverage report action from b03d096

[valkirilov]

Nice! Now, when I see how this PR fixed some limiting issues, I wonder whether it's a good idea to actually turn on the linter in the pipeline, so we don't produce new issues in the meantime.

The rest of the rules are still disabled, so it won't block us at the moment - it will simply guard us from producing new issues.

[pawelangelow]

Nice! Now, when I see how this PR fixed some limiting issues, I wonder whether it's a good idea to actually turn on the linter in the pipeline, so we don't produce new issues in the meantime.

The rest of the rules are still disabled, so it won't block us at the moment - it will simply guard us from producing new issues.

That's for sure. When I have some time, I'll open a PR about it, as it requires a bit of changes of our whole process. What I imagine is:

• install dependencies
• run linter + prettier
• fail if previous step failed
• continue with tests with cached dependencies (so we don't wait again for yarn install)

but it will be explained in a feature PR. This one at least improves the Dev experience over the backend.