Move auth calculation into refresh_token method #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using an endpoint with no
client_secret. I couldn't passclient_idto the endpoint as Basic auth unless I provided it as anauthkwarg to each request. However if theTokenExpiredErrorwas not raised, then thisauthwas passed through to the original request endpoint as it was not popped from kwargs (?overwriting the intended token auth).Based on the docs it seems like I should be able to pass
client_idthroughauto_refresh_kwargs(https://requests-oauthlib.readthedocs.io/en/latest/oauth2_workflow.html). However currentlyauthdoes not considerauto_refresh_kwargsat all.Changes assume that the intended behaviour is that the token refresh auth can be provided in
auto_refresh_kwargselse in the requestkwargs. And that aclient_secretis not mandatory.Note that
client_idandclient_secretwould still be passed down from the request method askwargs.More generally,
client_secretshould be required for token refresh byclient_idclient_idandclient_secretshould need to be provided in every request but rather be sourced at a session level (likeauto_refresh_kwargs) or from the client itself.