feat: change any by other types #761
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-by: Nathan Python <nathan.python@hes-so.ch
NathanPython2002
force-pushed
the
pyn-eslint
branch
from
151f658 to
be06a09
Compare
jma
approved these changes
Oct 22, 2025
Contributor
jma
left a comment
jma
left a comment
There was a problem hiding this comment.
I have approved this PR, but be sure that the broken es6 compatibility is in the commit message.
| } | ||
| } | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Not sure. This should be a choice of the dev.
| sort: string = null, | ||
| facets: string[] = [] | ||
| ): Observable<Record | Error> { | ||
| ): Observable<EsResult | Error> { |
Contributor
There was a problem hiding this comment.
This should be described in the commit message.
| headers: any = {} | ||
| ): Observable<any | Error> { | ||
| headers = {} | ||
| ): Observable<InvenioRecord> { |
Contributor
There was a problem hiding this comment.
This should be described in the commit message.
| ); | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Removing the ES6 compatibility should be mentioned in the commit message.
| hits : { | ||
| hits: InvenioRecord[], | ||
| total : { | ||
| relation : string, |
Contributor
There was a problem hiding this comment.
can be an enum of "eq", "gt', etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Nathan Python <nathan.python@hes-so.ch