-
Notifications
You must be signed in to change notification settings - Fork 76
Add vda5050 safety state msg #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add vda5050 safety state msg #266
Conversation
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One curious question, would it make sense to have it within the VDA5050State message?
Thanks @saikishor for the review! I considered including it directly within VDA5050State, but that message doesn’t currently have the same structure as the VDA5050 schema; it only includes a subset of fields and subfields from different sections. The message in this PR represents the complete In the future, if we decided to expand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes of this PR look good to me.
Just curious, if it makes sense to have them as uint8 enums instead of the strings. I also agree that VDA5050State uses strings within it. I just thought about this after looking at the guidelines in the following links
https://coatyio.github.io/vda-5050-lib.js/api/interfaces/SafetyStatus.html#eStop
https://github.com/coatyio/vda-5050-lib.js/blob/80345b2/src/common/vda-5050-types.ts#L1718
| @@ -0,0 +1,12 @@ | |||
| string e_stop # Enum {autoAck, manual, remote, none} Acknowledge-Type of eStop: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| string e_stop # Enum {autoAck, manual, remote, none} Acknowledge-Type of eStop: | |
| uint8 e_stop # Enum {autoAck, manual, remote, none} Acknowledge-Type of eStop: |
| string e_stop # Enum {autoAck, manual, remote, none} Acknowledge-Type of eStop: | |
| uint8 e_stop # Enum {autoAck, manual, remote, none} Acknowledge-Type of eStop: |
| # Enums for eStop | ||
| string AUTO_ACK="autoAck" | ||
| string MANUAL="manual" | ||
| string REMOTE="remote" | ||
| string NONE="none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Enums for eStop | |
| string AUTO_ACK="autoAck" | |
| string MANUAL="manual" | |
| string REMOTE="remote" | |
| string NONE="none" | |
| # Enums for eStop | |
| uint8 AUTO_ACK="autoAck" | |
| uint8 MANUAL="manual" | |
| uint8 REMOTE="remote" | |
| uint8 NONE="none" |
This PR introduces a new message definition:
VDA5050SafetyState.VDA5050SafetyStateprovides a standardized message for reporting the safety state of a robot or AGV in accordance with the VDA5050 schema. The fields and enumerations in this message are directly derived from the official VDA5050 specification to ensure compatibility with VDA5050-compliant fleet management systems and controllers.While this message already exists in the ipa320/vda5050_msgs package, it is being added to control_msgs to:
Enable direct integration with the upcoming
vda5050_safety_state_broadcasterinros2_controllers, andEnsure that the message is maintained and versioned alongside other core control interfaces.
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)