Turn autogenerated.urdf into a valid URDF #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to use existing assets to validate the implementation of the XSD, but the existing assets had data that was not valid URDF (i.e. gibberish type names like "type1"). Signed-off-by: Ezra Brooks <ezra@brooks.cx>
Author
|
My goal is to be able to add a test to this repository that validates the XSD implementation by checking against a known-valid URDF in CI. Right now (as evidenced by #229), we don't seem to have any automated validation of the schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use existing assets to validate the implementation of the XSD, but the existing assets had data that was not valid URDF (i.e. gibberish type names like "type1"). This file doesn't seem referenced anywhere so I don't think making changes to it breaks anything.
Also, like in #227, I formatted it using Prettier to make it more legible.