Skip to content

Port rcl events support #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 25, 2022
Merged

Port rcl events support #206

merged 11 commits into from
Jan 25, 2022

Conversation

@ivanpauno
Copy link
Contributor

@ivanpauno ivanpauno commented Jan 14, 2022

@ivanpauno
Some code that compiles and doesn't break existing tests (osrf#10)
b9e9fdd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add offered qos incompatible event and event executor test (osrf#11)
e80c5df 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Move events.publisher_statuses to publisher.statuses (osrf#12)
af60743 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add support for events in subscriptions (osrf#13)
1a50f3f 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add RequestedQosIncompatible subscription event status (osrf#14)
6c41709 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Test subscription events (osrf#15)
d3d740f 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add OfferedDeadlineMissed QoS event (osrf#17)
ac6f493 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Autoremove EventHandler from parent entity (osrf#16)
7e25190 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add RequestedDeadlineMissed subscription event (osrf#19)
a7b976d 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add LivelinessChanged subscription event (osrf#18)
ab00818 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add missing returns (osrf#23)
cb1c8fd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno requested a review from jacobperron January 14, 2022 14:48
@ivanpauno ivanpauno self-assigned this Jan 14, 2022
jacobperron
jacobperron approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit 434e6f5 into main Jan 25, 2022
@ivanpauno ivanpauno deleted the ivanpauno/port-rcl-events-support branch January 25, 2022 13:20
@jacobperron jacobperron mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpauno @jacobperron