-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Use delay_span_bug in validate-mir. #147712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes a file inside |
|
rustbot has assigned @jdonszelmann. Use |
This comment has been minimized.
This comment has been minimized.
|
Reminder, once the PR becomes ready for a review, use |
| @@ -1,6 +1,6 @@ | |||
| //@ known-bug: #140850 | |||
| //@ compile-flags: -Zvalidate-mir | |||
| fn A() -> impl { | |||
| fn A() -> impl Copy { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did this need to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the syntax error would hide the validation ICE.
|
@rustbot author |
|
r=me after fixing ci |
8b3f715 to
71bc112
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
The job Click to see the possible cause of the failure (guessed by this bot)For more information how to resolve CI failures of this job, visit this link. |
Fixes #126680
Fixes #137916
Fixes #146210 (dup of #137916)