Skip to content

Conversation

@cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Oct 15, 2025

Fixes #126680
Fixes #137916
Fixes #146210 (dup of #137916)

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor

looks reasonable to me, could you rebase @cjgillot?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@@ -1,6 +1,6 @@
//@ known-bug: #140850
//@ compile-flags: -Zvalidate-mir
fn A() -> impl {
fn A() -> impl Copy {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this need to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the syntax error would hide the validation ICE.

@jdonszelmann
Copy link
Contributor

@rustbot author

@jdonszelmann
Copy link
Contributor

r=me after fixing ci

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-gcc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [crashes] tests/crashes/88296.rs ... ok
test [crashes] tests/crashes/93182.rs ... ok
test [crashes] tests/crashes/94846.rs ... ok
test [crashes] tests/crashes/98322.rs ... ok
2025-10-24T03:41:57.021136Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/project-to-simd-array-field.rs ... FAILED
test [crashes] tests/crashes/93237.rs ... ok
test [crashes] tests/crashes/108499.rs ... ok

failures:

---- [crashes] tests/crashes/project-to-simd-array-field.rs stdout ----
------rustc stdout------------------------------

------rustc stderr------------------------------
warning: type `i32x3` is more private than the item `simd_add_self_then_return_array_packed`
##[warning]  --> /checkout/tests/crashes/project-to-simd-array-field.rs:27:1
   |
27 | pub fn simd_add_self_then_return_array_packed(a: i32x3) -> [i32; 3] {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `simd_add_self_then_return_array_packed` is reachable at visibility `pub`
   |
note: but type `i32x3` is only usable at visibility `pub(crate)`
  --> /checkout/tests/crashes/project-to-simd-array-field.rs:14:1
   |
14 | struct i32x3([i32; 3]);
   | ^^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default

libgccjit.so: error: : gcc_jit_type_get_vector: num_units not a power of two: 3
gcc_jit_type_get_pointer: NULL type
gcc_jit_type_get_restrict: NULL type
libgccjit.so: error: : gcc_jit_context_new_param: NULL type
libgccjit.so: error: : gcc_jit_context_new_function: NULL parameter 1 creating function _ZN27project_to_simd_array_field9to_array317hee8544386b15f19dE
gcc_jit_function_add_integer_array_attribute: NULL func
gcc_jit_function_add_attribute: NULL func
gcc_jit_function_add_attribute: NULL func
gcc_jit_type_get_pointer: NULL type
gcc_jit_type_get_restrict: NULL type
libgccjit.so: error: : gcc_jit_context_new_param: NULL type
libgccjit.so: error: : gcc_jit_context_new_function: NULL parameter 1 creating function simd_add_self_then_return_array_packed
gcc_jit_function_add_integer_array_attribute: NULL func
gcc_jit_function_new_block: NULL function
gcc_jit_block_get_function: NULL block
gcc_jit_function_get_param: NULL function
gcc_jit_param_as_rvalue: NULL param
gcc_jit_block_get_function: NULL block
gcc_jit_function_get_param: NULL function
gcc_jit_param_as_rvalue: NULL param
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_type_is_pointer: NULL type
gcc_jit_type_get_pointer: NULL type
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_compatible_types: NULL ltype
gcc_jit_compatible_types: NULL ltype
gcc_jit_compatible_types: NULL ltype
gcc_jit_compatible_types: NULL ltype
gcc_jit_type_unqualified: NULL type
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL ltype
libgccjit.so: error: : gcc_jit_context_new_array_access: NULL ptr
gcc_jit_lvalue_as_rvalue: NULL lvalue
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_type_is_pointer: NULL type
gcc_jit_type_get_pointer: NULL type
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_compatible_types: NULL ltype
gcc_jit_compatible_types: NULL ltype
gcc_jit_compatible_types: NULL ltype
gcc_jit_compatible_types: NULL ltype
gcc_jit_type_unqualified: NULL type
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL ltype
libgccjit.so: error: : gcc_jit_context_new_array_access: NULL ptr
gcc_jit_lvalue_as_rvalue: NULL lvalue
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
libgccjit.so: error: : gcc_jit_context_new_call: NULL argument 1 to function "memcpy": param arg0 (type: void *)
gcc_jit_block_add_eval: NULL block
gcc_jit_block_end_with_void_return: NULL block
gcc_jit_function_new_block: NULL function
gcc_jit_block_get_function: NULL block
gcc_jit_function_get_param: NULL function
gcc_jit_param_as_rvalue: NULL param
gcc_jit_block_get_function: NULL block
gcc_jit_function_get_param: NULL function
gcc_jit_param_as_rvalue: NULL param
gcc_jit_block_get_function: NULL block
gcc_jit_function_new_local: NULL function
gcc_jit_lvalue_get_address: NULL lvalue
gcc_jit_block_get_function: NULL block
gcc_jit_type_get_aligned: NULL type
gcc_jit_type_get_pointer: NULL type
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_function_new_local: NULL function
gcc_jit_block_add_assignment: NULL block
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_block_get_function: NULL block
gcc_jit_type_get_aligned: NULL type
gcc_jit_type_get_pointer: NULL type
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_function_new_local: NULL function
gcc_jit_block_add_assignment: NULL block
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL rtype
gcc_jit_compatible_types: NULL ltype
gcc_jit_type_dyncast_vector: NULL type
gcc_jit_type_unqualified: NULL type
gcc_jit_compatible_types: NULL ltype
libgccjit.so: error: : gcc_jit_context_new_param: NULL type
libgccjit.so: error: : gcc_jit_context_new_param: NULL type
libgccjit.so: error: : gcc_jit_context_new_function: NULL return_type
libgccjit.so: error: : gcc_jit_context_new_call: NULL function
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_type_get_pointer: NULL type
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_type_unqualified: NULL type
gcc_jit_type_get_aligned: NULL type
gcc_jit_type_get_pointer: NULL type
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_block_add_assignment: NULL block
gcc_jit_block_get_function: NULL block
gcc_jit_type_get_aligned: NULL type
gcc_jit_type_get_pointer: NULL type
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_function_new_local: NULL function
gcc_jit_block_add_assignment: NULL block
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_block_get_function: NULL block
gcc_jit_function_new_local: NULL function
gcc_jit_lvalue_get_address: NULL lvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_type_get_pointer: NULL type
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_rvalue_get_type: NULL rvalue
gcc_jit_type_unqualified: NULL type
gcc_jit_type_get_aligned: NULL type
gcc_jit_type_get_pointer: NULL type
libgccjit.so: error: : gcc_jit_context_new_cast: NULL rvalue
gcc_jit_rvalue_dereference: NULL rvalue
gcc_jit_block_add_assignment: NULL block
gcc_jit_function_get_address: NULL function
gcc_jit_type_get_pointer: NULL type
gcc_jit_type_get_restrict: NULL type
libgccjit.so: error: : gcc_jit_context_new_function_ptr_type: NULL parameter type 1 creating function pointer type
gcc_jit_function_get_param_count: NULL function
gcc_jit_function_get_return_type: NULL function_type
gcc_jit_block_get_function: NULL block
gcc_jit_function_new_local: NULL function
libgccjit.so: error: : gcc_jit_context_new_call: NULL function
gcc_jit_block_add_assignment: NULL block
gcc_jit_lvalue_as_rvalue: NULL lvalue
gcc_jit_block_end_with_void_return: NULL block
error: failed to build archive at `/checkout/obj/build/x86_64-unknown-linux-gnu/test/crashes/project-to-simd-array-field/libproject_to_simd_array_field.rlib`: failed to open object file: No such file or directory (os error 2)

error: aborting due to 1 previous error; 1 warning emitted


------------------------------------------

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/project-to-simd-array-field.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error
stack backtrace:
   5: __rustc::rust_begin_unwind

For more information how to resolve CI failures of this job, visit this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

4 participants