Add try_create and loopback_test for SerialPort #31
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
fixes #30
This adds
try_createandloopback_testtoSerialPort.The reason AFAICT is that
newis aconst fnwhich would not be possible ifinitis done at the same time. Thereforloopback_testis a separate function that can be used independent of the newtry_create.I was considering also adding a
loopback_test_with_datato allow the caller to specify what byte to use for the loopback test, but I can't think of any good reason why this would be needed, and it can always be added in the future.There are 2 issues I can still see with the PR.
Result<(), ()>andResult<Self, ()>feels a bit cluncky. For the second we could useOptionbut I personally don't like using option for errors, even if there isn't a specific reason. Maybe add we could add astruct LoopbackTestFailure {}.initwill crash anyways or it is mapped but just to regular memory in which case a loopback test will always succed.Let me know if there is anything that I should adjust.