- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1k
 
Update the nightlies doc #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the nightlies doc #3213
Conversation
repo.scala-lang.org
      08bece9    to
    69bb7c6      
    Compare
  
            
          
                _overviews/core/nightlies.md
              
                Outdated
          
        
      | 
               | 
          ||
| Note how the custom `JvmWorkerModule` is necessary with the added repository. It is not enough to just define it as a repository for the module dependencies. | ||
| 
               | 
          ||
| Also note that Mill 1.0.5 or newer is necessary for this. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: 1.0.5 is not out yet, although as per Discord discussion, it should be out soon.
Example was tested with Mill 1.0.4-53-a211b4 (it's already working on the nightly Mill version).
cc @lihaoyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mill 1.0.5 is freshly out, so that's solved.
https://github.com/com-lihaoyi/mill/releases/tag/1.0.5
repo.scala-lang.org69bb7c6    to
    94fbd48      
    Compare
  
    | //> using scala 2.nightly | ||
| ### SBT | ||
| 
               | 
          ||
| ### Longer explanation | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Longer explanation section feels redundant now, at least for the scope of this document, so I ended up removing it.
repo.scala-lang.org proxies to Scala 2 nightlies, so that part is basically an implementation detail.
Let me know if we want to preserve it somewhere.
cc @SethTisue @lrytz
| 
           Since repo.scala-lang.org proxies to Scala 2 nightlies, I ended up merging the Scala 2 and 3 sections to a large extent, and removed some stuff that no longer feels necessary.  | 
    
942a799    to
    f6abe39      
    Compare
  
    11c2739    to
    6841130      
    Compare
  
    | 
           I think this is now mergeable, and I suggest we merge it promptly, to make the information available now. I have some ideas for tweaks and adjustments, but I can put that in a separate PR.  | 
    
| 
           maybe the "Longer explanation" part could be internal documentation in https://github.com/scala/internal-docs instead?  | 
    
6841130    to
    40c7c93      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
For Scala 2, the easiest way to find a specific mergely version number is to go to https://github.com/scala/scala/commits/2.13.x, find the merge commit that you want to try out, click on the "checks", scroll down to the one from travis. The version number shows up there.
Mabye that could be included?
40c7c93    to
    2319e2d      
    Compare
  
    
          
 IMO that's a bit complex, while one can find it way easier at https://repo.scala-lang.org/artifactory/maven-nightlies or via Scala CLI... we can mention it in internal docs, but perhaps not in user facing ones.  | 
    
          
 Yes, suggesting to people all of these steps is just wrong. We should fine a better way. For now, I think it's okay. I will do a last review now and approve it.  | 
    
Co-authored-by: Hamza Remmal <hamza@remmal.net>

Fixes #3206