Possibility to override versions #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables running: `make all IMAGEMAGICK_VERSION=7.0.9-20` We conditionally pass parameters like `IMAGEMAGICK_VERSION=7.0.9-20` when invoking `make` inside Docker. The `DOCKER_MAKE_PARAMS` contains conditions to only have the parameters that are not empty. Otherwise we would pass empty variables like `IMAGEMAGICK_VERSION=` and the conditional parameter in `Makefile_ImageMagick` like `IMAGEMAGICK_VERSION ?= 7.0.8-45` would not get applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables running:
make all IMAGEMAGICK_VERSION=7.0.9-20We conditionally pass parameters like
IMAGEMAGICK_VERSION=7.0.9-20when invokingmakeinside Docker.The
DOCKER_MAKE_PARAMScontains conditions to only have the parameters that are not empty. Otherwise we would pass empty variables likeIMAGEMAGICK_VERSION=and the conditional parameter inMakefile_ImageMagicklikeIMAGEMAGICK_VERSION ?= 7.0.8-45would not get applied.