SG-39106 Cleanup unused RV authentication module

python/tank/authentication/login_dialog.py

@@ -43,7 +43,7 @@
 from . import site_info
 from .sso_saml2 import (
     SsoSaml2IncompletePySide2,
-    SsoSaml2Toolkit,
+    SsoSaml2,
     SsoSaml2MissingQtModuleError,
 )
 
@@ -153,7 +153,7 @@ def __init__(
             "QtWebEngineWidgets": QtWebEngineWidgets,
         }
         try:
-            self._sso_saml2 = SsoSaml2Toolkit(
+            self._sso_saml2 = SsoSaml2(
                 "Flow Production Tracking Web Login", qt_modules=qt_modules
             )
         except SsoSaml2MissingQtModuleError as e:

python/tank/authentication/sso_saml2/__init__.py

@@ -25,8 +25,6 @@
 # Classes
 from .sso_saml2 import SsoSaml2  # noqa
 
-from .sso_saml2_toolkit import SsoSaml2Toolkit  # noqa
-
 # Functions
 from .utils import (  # noqa
     get_saml_claims_expiration,

python/tank/authentication/sso_saml2/sso_saml2.py

@@ -135,3 +135,16 @@
         :returns: The session error string or ""
         """
         return self._core._session.error
+
+    def get_session_data(self):
+        """
+        Get a minimal subset of session data, for the Shotgun Toolkit.
+
+        :returns: A tuple of the hostname, user_id, session_id and cookies.
+        """
+        return (
+            self._core._session.host,
+            self._core._session.user_id,
+            self._core._session.session_id,
+            self._core._session.cookies,
+        )

tests/authentication_tests/test_interactive_authentication.py

@@ -110,9 +110,9 @@ def done(self, r):
                 self.my_result = r
                 return super(MyLoginDialog, self).done(r)
 
-        # Patch out the SsoSaml2Toolkit class to avoid threads being created, which cause
+        # Patch out the SsoSaml2 class to avoid threads being created, which cause
         # issues with tests.
-        with mock.patch("tank.authentication.login_dialog.SsoSaml2Toolkit"):
+        with mock.patch("tank.authentication.login_dialog.SsoSaml2"):
             with contextlib.closing(MyLoginDialog(is_session_renewal, **kwargs)) as ld:
                 try:
                     self._prepare_window(ld)

tests/authentication_tests/test_web_login.py

@@ -17,7 +17,7 @@
     skip_if_pyside_missing,
 )
 
-from tank.authentication.sso_saml2 import SsoSaml2Toolkit
+from tank.authentication.sso_saml2 import SsoSaml2
 
 
 @only_run_on_nix  # This test issues a seg-fault on Windows
@@ -36,7 +36,7 @@ def test_web_login(self):
         if qt_abstraction.QtGui.QApplication.instance() is None:
             self._app = qt_abstraction.QtGui.QApplication([])
 
-        obj = SsoSaml2Toolkit(
+        obj = SsoSaml2(
             "Test Web Login",
             qt_modules={
                 "QtCore": qt_abstraction.QtCore,