Add routine and test for the solar eclipse calculation. #1076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding routine and test for finding solar eclipses.
It uses similar method as lunar eclipse calculation, but instead of looking for maximum of angle between earth-sun and earth-moon, it looks for minimum.
Solar eclipse routine also:
The agreement of routine results with the official data for the last ~400 years is rather good.
E.g., the few misidentifications of eclipse type are for the eclipses that last 0 seconds.
The few eclipses that are not found or found extra, are for low magnitude partial eclipses, where, e.g., using polar earth radius versus equatorial, would make the difference for the eclipse identification.