-
Notifications
You must be signed in to change notification settings - Fork 77
Add descriptor for non-supported coverage and fix duplicate languages #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Right now coverage blocks where isSupported=False and type=FAILED_PARSING end up in the coverage section of the report and cannot be differentiated from success. This change just adds the type of coverage in brackets if the type is not supported. Signed-off-by: Ian Zink <zforce@gmail.com>
Your PR has not had any activity for 60 days. In 2 days I'll close it. Make some activity to remove this. |
bump |
Your PR has not had any activity for 60 days. In 2 days I'll close it. Make some activity to remove this. |
Your PR has now been stale for 2 days. I'm closing it. |
Just wanted to bring this one back |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Your PR has not had any activity for 60 days. In 2 days I'll close it. Make some activity to remove this. |
Your PR has now been stale for 2 days. I'm closing it. |
Reopen, we really need this or something like it as the current code allows for a bug where languages show up twice |
@z4ce we need some kind of automatic test that can provoke this error without your changes, and then pass with your changes. Are you able to add this? The visual regression tests are failing due to seemingly some width has changed, which seems harmless though, but they will have to be regenerated. Will this be possible? |
What this does
Right now coverage blocks where isSupported=False and type=FAILED_PARSING end up in the coverage section of the report and cannot be differentiated from success. This change just adds the type of coverage in brackets if isSupported is false.
Example input snippet:
Right now it renders as
After this PR it renders as:

Here is an example file with a file that has failed to parse:
test.json