Skip to content

Conversation

z4ce
Copy link
Contributor

@z4ce z4ce commented Mar 19, 2024

What this does

Right now coverage blocks where isSupported=False and type=FAILED_PARSING end up in the coverage section of the report and cannot be differentiated from success. This change just adds the type of coverage in brackets if isSupported is false.

Example input snippet:

"properties": {
        "coverage": [
          {
            "isSupported": true,
            "lang": "XML",
            "files": 3,
            "type": "SUPPORTED"
          },
          {
            "isSupported": true,
            "lang": "HTML",
            "files": 13,
            "type": "SUPPORTED"
          },
          {
            "isSupported": true,
            "lang": "Java",
            "files": 39,
            "type": "SUPPORTED"
          },
          {
            "isSupported": false,
            "lang": "Java",
            "files": 1,
            "type": "FAILED_PARSING"
          }
        ]
      }

Right now it renders as

image

After this PR it renders as:
image

Here is an example file with a file that has failed to parse:
test.json

Right now coverage blocks where isSupported=False and
type=FAILED_PARSING end up in the coverage section of the report
and cannot be differentiated from success. This change just
adds the type of coverage in brackets if the type is not supported.

Signed-off-by: Ian Zink <zforce@gmail.com>
@z4ce z4ce requested a review from a team as a code owner March 19, 2024 19:13
Copy link

Your PR has not had any activity for 60 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Mar 26, 2025
@z4ce
Copy link
Contributor Author

z4ce commented Mar 26, 2025

bump

@github-actions github-actions bot removed the Stale label Mar 27, 2025
Copy link

Your PR has not had any activity for 60 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label May 26, 2025
Copy link

Your PR has now been stale for 2 days. I'm closing it.

@github-actions github-actions bot closed this May 29, 2025
@z4ce
Copy link
Contributor Author

z4ce commented Jun 17, 2025

Just wanted to bring this one back

@z4ce z4ce reopened this Jun 17, 2025
Copy link

snyk-io bot commented Jun 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@github-actions github-actions bot removed the Stale label Jun 18, 2025
Copy link

Your PR has not had any activity for 60 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Aug 27, 2025
Copy link

Your PR has now been stale for 2 days. I'm closing it.

@github-actions github-actions bot closed this Aug 30, 2025
@z4ce
Copy link
Contributor Author

z4ce commented Sep 1, 2025

Reopen, we really need this or something like it as the current code allows for a bug where languages show up twice

@z4ce z4ce reopened this Sep 1, 2025
@z4ce z4ce requested a review from a team as a code owner September 1, 2025 00:10
@github-actions github-actions bot removed the Stale label Sep 1, 2025
@dotkas
Copy link
Contributor

dotkas commented Sep 1, 2025

@z4ce we need some kind of automatic test that can provoke this error without your changes, and then pass with your changes. Are you able to add this?

The visual regression tests are failing due to seemingly some width has changed, which seems harmless though, but they will have to be regenerated.

Will this be possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants