-
Notifications
You must be signed in to change notification settings - Fork 41
fix(workbench): Deleting a dataset navigates you away form current page. #7519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ot reload the page yet
Fixed the redirection issues, now attempting to solve new issue that does not redirect the user away from an open dataset they've just deleted through the DatasetMeta Delete button
Triggered by 66983cb on branch refs/heads/issue-4921
Triggered by c8a956c on branch refs/heads/issue-4921
…le event unsubscription while not on Workbench
Triggered by 385c072 on branch refs/heads/issue-4921
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21648217 | Triggered | Generic Password | dbb1e96 | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
1 similar comment
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21648217 | Triggered | Generic Password | dbb1e96 | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Triggered by dbb1e96 on branch refs/heads/issue-4921
Fixes #4921
Fixed issue that caused the deletion of a workbench dataset through the dataset meta menu to always redirect the user away from their current page, regardless if they were on the deleted dataset or not. You should only be redirected if the dataset you deleted is the dataset you were on
Previous behavior:
prev.mov
Fixed behavior:
Screen.Recording.2025-10-29.at.10.28.01.AM.mov
Checklist
self-explanatory (or properly documented)
Testing instructions
Note: ignore the current failing tests, git guardian is being mean. Tests have been verified locally.