Add McpClientHandlersRegistry #4802
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kehrlann
force-pushed
the
dgarnier/mcp-client-handlers-registry
branch
5 times, most recently
from
cfce918 to
4835ccc
Compare
Kehrlann
changed the title
Kehrlann
force-pushed
the
dgarnier/mcp-client-handlers-registry
branch
from
4835ccc to
2b1f49b
Compare
Kehrlann
force-pushed
the
dgarnier/mcp-client-handlers-registry
branch
3 times, most recently
from
52676cd to
18e986a
Compare
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
- In febf86c, we broke a dependency cycle ChatClient -> McpClient - With the introduction of ClientMcpSyncHandlersRegistry and the async variant, there is no dependency McpClient -> MCP handlers anymore, breaking the cycle in a simpler way. - Here, we revert most of the changes of febf86c, but keep the tests. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/mcp-client-handlers-registry
branch
2 times, most recently
from
b524ddd to
ad8d987
Compare
- Remove custom class resolution method and use AutoProxyUtils instead Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/mcp-client-handlers-registry
branch
from
ad8d987 to
4ab6503
Compare
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
tzolov
approved these changes
Nov 6, 2025
| if (!foundAnnotations.isEmpty()) { | ||
| this.allAnnotatedBeans.add(beanName); | ||
| } | ||
| for (var foundAnnotation : foundAnnotations) { |
There was a problem hiding this comment.
I guess this block can be nested in side the if (!foundAnnotations.isEmpty()) { above
|
|
||
| for (var beanName : this.allAnnotatedBeans) { | ||
| var bean = this.beanFactory.getBean(beanName); | ||
| var annotations = scan(bean.getClass()); |
| // Only process singleton beans, not scoped beans | ||
| continue; | ||
| } | ||
| var foundAnnotations = scan(AutoProxyUtils.determineTargetClass(beanFactory, beanName)); |
There was a problem hiding this comment.
this prefix (e.g. this.scan)
|
|
||
| @Override | ||
| public void afterSingletonsInstantiated() { | ||
| var beansByAnnotation = getBeansByAnnotationType(); |
|
|
||
| @Override | ||
| public void afterSingletonsInstantiated() { | ||
| var beansByAnnotation = getBeansByAnnotationType(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4670
This PR introduces two variants (sync and async) of a "registry" of handlers,
ClientMcpSyncHandlersRegistry.These registries have two main responsibilities:
This allows to break the dependency between MCP clients and MCP-annotated beans. This was a problem when doing sampling, where there was a cycle MCP Client -> MCP handlers -> ChatClient -> MCP Client.
With this PR, the MCP clients depend on the registry, but the registry does not depend on the MCP-handlers. Instead, it discovers them dynamically and makes handlers available by client name. See #4751 for the initial attempt at fixing the circular dependency.
The flow to capture annotations has two steps:
BeanFactoryPostProcessor. Bean types are scanned for annotations, and the bean names found are recorded for later use. Additionally,@McpSamplingand@McpElicitationannotations are tracked per client name. This allows to bootstrap MCP clients in theMcpClientAutoConfiguration: by the time the clients are created, we know their capabilities, even if the annotated beans have not been instantiated yet.SmartInitializingSingleton, actual bean instances are retrieved, and from the bean instances and annotated methods, MCP handlers are populated in the registry, stored by client name.Notes: