-
Couldn't load subscription status.
- Fork 41.6k
Document that Actuator endpoint may have at most one extension of each type #47740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| You can write technology-specific extensions by using javadoc:org.springframework.boot.actuate.endpoint.web.annotation.EndpointWebExtension[format=annotation] and javadoc:org.springframework.boot.actuate.endpoint.jmx.annotation.EndpointJmxExtension[format=annotation]. | ||
| These annotations let you provide technology-specific operations to augment an existing endpoint. | ||
|
|
||
| NOTE: As of now, it is possible to have only a single extension per an individual javadoc:org.springframework.boot.actuate.endpoint.annotation.Endpoint[format=annotation]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR but I don't think this is accurate as an individual endpoint can have both a Web extension and a JMX extension. It's only multiple JMX extensions or multiple Web extensions that are not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, thank you for the clarification, @wilkinsona. Changed the wording here.
Signed-off-by: mipo256 <mikhailpolivakha@email.com> Signed-off-by: Mikhail Polivakha <mikhailpolivakha@email.com>
| You can write technology-specific extensions by using javadoc:org.springframework.boot.actuate.endpoint.web.annotation.EndpointWebExtension[format=annotation] and javadoc:org.springframework.boot.actuate.endpoint.jmx.annotation.EndpointJmxExtension[format=annotation]. | ||
| These annotations let you provide technology-specific operations to augment an existing endpoint. | ||
|
|
||
| NOTE: As of now, it is not possible to have multiple javadoc:org.springframework.boot.actuate.endpoint.web.annotation.EndpointWebExtension[format=annotation] or javadoc:org.springframework.boot.actuate.endpoint.jmx.annotation.EndpointJmxExtension[format=annotation] extensions per a single javadoc:org.springframework.boot.actuate.endpoint.annotation.Endpoint[format=annotation]. However, it is possible to have both javadoc:org.springframework.boot.actuate.endpoint.web.annotation.EndpointWebExtension[format=annotation] and javadoc:org.springframework.boot.actuate.endpoint.jmx.annotation.EndpointJmxExtension[format=annotation] for a single javadoc:org.springframework.boot.actuate.endpoint.annotation.Endpoint[format=annotation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than this note, I wonder if it would be better to add a sentence to the proceeding paragraph. Something like the following:
"An endpoint may have at most one extension of each type".
WDYT?
No description provided.