Skip to content

Conversation

@pgawlowicz
Copy link

@pgawlowicz pgawlowicz commented Jul 5, 2023

Two commits to allow for a graceful exit:

Commit 1: Without the commit, we get the following error when running tests:

# ./waterfallplot_test_c
Qt has caught an exception thrown from an event handler. Throwing
exceptions from an event handler is not supported in Qt.
You must not let any exception whatsoever propagate through Qt code.
If that is not possible, in Qt 5 you must at least reimplement
QCoreApplication::notify() and catch all exceptions there.

Commit 2: check if the application was closed (e.g. using a close button). Without this commit, it tries to send a blocking signal to destroy a widget and hangs as there is no app to receive it.

@pgawlowicz pgawlowicz requested a review from andrepuschmann July 5, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants