-
Notifications
You must be signed in to change notification settings - Fork 23
CI: Add better/longer retries to AIO workflow TF #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
The one time I want to test a CI failure, every AIO works perfectly first time 🙃 |
b2ecf4f to
c5fc4fa
Compare
c5fc4fa to
6ba3f40
Compare
6ba3f40 to
62e53e0
Compare
priteau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jump from 60-180 seconds to 7200 is huge (an exponential backoff is more conventional), but let's see how it works. We can keep tuning it.
Previously, the terraform apply would just run 5 times. If it failed, it would wait 60 seconds.
All AIOs are triggered at the same time, so might conflict.
Now, it runs 6 times. After 3 attempts, wait for 2 hours (the cloud is probably at capacity, waits for other jobs to finish)
Normal waits are randomised from 1 to 3 minutes