Fix split views on Catalyst #229
Conversation
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Thanks for looking into this. When testing out your changes locally I managed to make the app freeze in a resize handling update loop indefinitely by resizing the app a bunch and getting unlucky. I reproduced that behaviour a few times and couldn't on main so I think there may be some sort of feedback loop in your current layoutSubviews-based approach. I'm not exactly sure what the solution is to that.
I also noticed that the splits get allocated rather strange sizes (especially when you switch to the three column example), but I get the same behaviour on main so that doesn't necessarily need to be fixed in this PR.
|
|
||
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| splitWidget.resizeHandler?() |
There was a problem hiding this comment.
Does this trigger the resize handler twice given that both columns would get laid out and end up both calling it?
There was a problem hiding this comment.
You're right, it totally would. I assume we do want to trigger it if only one of the views has resized for some reason (column size change and window size change cancelling out?) so I'll need to think about how to fix this
2 participants
Draft until I can test that I didn't break it on iPad