proposed changes to replit template #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-reid
force-pushed
the
testing-new-format
branch
from
ac37e0f to
f570ccf
Compare
eob
approved these changes
Jan 25, 2023
| def generate(self, **prompt_args) -> str: | ||
| """Generate text from prompt parameters.""" | ||
| llm_config = { | ||
| "max_words": 30, # Controls length of generated output. |
There was a problem hiding this comment.
nit - spacing is funny with the comments here
|
|
||
|
|
||
| # Try it out locally by running this file! | ||
| # You'll need to set the STEAMSHIP_API_KEY environment variable |
There was a problem hiding this comment.
I think both comments or main print statement are both fine. Thinking out loud -- a nearly LoC-neutral change would be instead of the comments:
if name == "main":
if not os.environ.get('STEAMSHIP_API_KEY'):
print("Please set the STEAMSHIP_API_KEY environment variable. You can get one at ")
exit(-1)
Also we could put a:
Steamship.check_environment(type="replit", exit=True)
helper in?
| print("Generating compliments:") | ||
|
|
||
| inputs = [ | ||
| ('Dave', 'prompt creation'), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT COMMIT.
Only for review / collaboration purposes.