🚸(frontend) separate viewers from editors #1509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
renovate/js-dependencies
branch
3 times, most recently
from
196d1d7 to
145c688
Compare
We move some components related to doc versioning into the doc-versioning feature folder to have a better separation of concerns. We don't need a provider for the doc versioning components since they will receive the doc data directly via a request.
AntoLC
force-pushed
the
enhance/remove-awareness-viewer
branch
from
682c578 to
7b708bb
Compare
|
Size Change: -921 B (-0.03%) Total Size: 3.68 MB
|
We are now totally separating the viewers with the editors. We will not load the provider when we are in viewer mode, meaning the viewers will not be aware of other users and will not show their cursors anymore. We still get the document updates in real-time.
In many places the property name "listInvalidQueries" was misspelled.
AntoLC
force-pushed
the
enhance/remove-awareness-viewer
branch
from
7b708bb to
781e1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are now totally separating the viewers with the editors.
We will not load the provider when we are in viewer mode, meaning the viewers will not be aware of other users and will not show their cursors anymore.
We still get the document updates in real-time.