Unconditionally add test targets #9329
Open
+27
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since some test targets were being "guarded" behind an environment variable, they were not being executed and were hiding an issue in CI as these tests were being excluded from the Package manifest in the smoke tests pipelies, and were being skipped in the self-hosted pipelines. Since the impacted tests run an end-to-end tests, and the smoke tests pipeline does a partial toolchain build, let's ensure these tests are executed as part of the smoke tests.
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some test targets were being "guarded" behind an environment variable, they were not being executed and were hiding an issue in CI as these tests were being excluded from the Package manifest in the smoke tests pipelies, and were being skipped in the self-hosted pipelines.
Since the impacted tests run an end-to-end tests, and the smoke tests pipeline does a partial toolchain build, let's ensure these tests are executed as part of the smoke tests.
Requires: #9318