Ensure the extension activates with a .bsp folder #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
plemarquand
force-pushed
the
fix-bsp-activation
branch
from
6d8aa91 to
9a64919
Compare
|
This can be verified with a project like https://github.com/spotify/sourcekit-bazel-bsp/tree/main/Example |
|
This can be verified with a project like https://github.com/spotify/sourcekit-bazel-bsp/tree/main/Example |
award999
reviewed
Oct 2, 2025
src/utilities/workspace.ts
Outdated
| } | ||
|
|
||
| await globDirectory(folder, { onlyDirectories: true }).then(async entries => { | ||
| const skipFolders = new Set<string>([ |
There was a problem hiding this comment.
probably should make this list a setting to allow excluding others and maybe user may want to add one of these folder. I'm thinking maybe bazel could generate a package for them possibly...
There was a problem hiding this comment.
I agree, I'll make the change
rbenegal
reviewed
Oct 2, 2025
plemarquand
force-pushed
the
fix-bsp-activation
branch
from
73da576 to
38464ac
Compare
rbenegal
reviewed
Oct 6, 2025
A .bsp folder was considered a valid workspace folder, but the extension acitvation events in the package.json were not configured to search for it, meaning another valid file/folder for activation had to be present. If that was the case, then the .bsp folder would be discovered correctly, but not if it was the only file/folder in the folder that would activate the extension. Add it to the list of valid activation file types. Also clean up this code path a bit, ignoring common folders we shouldn't search for projects.
plemarquand
force-pushed
the
fix-bsp-activation
branch
from
38464ac to
e8f15fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A .bsp folder was considered a valid workspace folder, but the extension activation events in the package.json were not configured to search for it, meaning another valid file/folder for activation had to be present. If that was the case, then the .bsp folder would be discovered correctly, but not if it was the only file/folder in the folder that would activate the extension.
Add it to the list of valid activation file types. Also clean up this code path a bit, ignoring common folders we shouldn't search for projects.
Tasks
Required tests have been writtenDocumentation has been updatedAdded an entry to CHANGELOG.md if applicable