[Notifier] Updated chatter documentation with Telegram::answerCallbackQuery
#17514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
Telegram::answerCallbackQuery
OskarStark
reviewed
Dec 5, 2022
notifier/chatters.rst
Outdated
Comment on lines
335
to
336
| Answering Callback Queries in Telegram | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Suggested change
| Answering Callback Queries in Telegram | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| Answering Callback Queries in Telegram | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
I don't quite understand why amount of ~ characters here should be more than in Updating Telegram Messages title case above
There was a problem hiding this comment.
For RST it just needs a minimum of three characters (IIRC), but in the Symfony docs we make as long as the title itself
There was a problem hiding this comment.
Oh, ok. Somehow I did not get it. Thank you, updated the file
notifier/chatters.rst
Outdated
Comment on lines
352
to
354
| $callbackQueryId = '12345', // extracted from callback | ||
| $showAlert = true, | ||
| $cacheTime = 1, |
There was a problem hiding this comment.
Suggested change
| $callbackQueryId = '12345', // extracted from callback | |
| $showAlert = true, | |
| $cacheTime = 1, | |
| callbackQueryId: '12345', // extracted from callback | |
| showAlert: true, | |
| cacheTime: 1, |
WDYT of using named arguments here?
There was a problem hiding this comment.
Yes, I like it, thank you
OskarStark
approved these changes
Dec 5, 2022
OskarStark
force-pushed
the
notifier-telegram-answer-callback-query
branch
from
4139340 to
c22c47b
Compare
|
Thanks Alex for working on this feature, this is much appreciated. |
|
Thank you very much, Oskar, for reviewing and helping with PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation for the new feature of Telegram notifier: answer callback query.
Fixes #17501