roles: update opts on config reload #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themilchenko
force-pushed
the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
2 times, most recently
from
66ad8e7 to
3105f0a
Compare
|
Maybe the target issue is #216? |
themilchenko
force-pushed
the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
from
3105f0a to
07d6404
Compare
I don't know how I missed this, thank you very much! |
DerekBum
reviewed
Oct 23, 2025
themilchenko
force-pushed
the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
from
07d6404 to
ac601f5
Compare
DerekBum
approved these changes
Oct 23, 2025
DifferentialOrange
approved these changes
Oct 23, 2025
themilchenko
force-pushed
the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
2 times, most recently
from
45a000c to
2668aba
Compare
themilchenko
force-pushed
the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
from
2668aba to
b80bec5
Compare
Changing the address during a configuration reload resulted in incorrect assertions, which always recreated the server. After this patch server will recreate itself only in changing a listen parameter. Closes #219
Global log level settings were declared that were only used in one test, but all tests in group were re-run because of it. This patch fixes it and update config with its log level only for this test.
There were no way to update config on the run with method `config:reload()` instead of listen parameters. This patch fixes it, all options support config reload. Closes #216
Since Debain buster distribution has reached its end-of-life building on it is no longer supported.
themilchenko
force-pushed
the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
from
b80bec5 to
b1f18ba
Compare
themilchenko
requested review from
DerekBum,
DifferentialOrange and
ita-sammann
DerekBum
approved these changes
Oct 24, 2025
|
|
||
| ## Fixed | ||
|
|
||
| - Do not recreate server if it's address and port were not changed (#219). |
There was a problem hiding this comment.
Suggested change
| - Do not recreate server if it's address and port were not changed (#219). | |
| - Do not recreate server if it's address and port were not changed (#216). |
There was a problem hiding this comment.
There is a new issue on this problem
DifferentialOrange
approved these changes
Oct 24, 2025
ita-sammann
approved these changes
Oct 24, 2025
sergos
deleted the
themilchenko/gh-216-fix-update-opts-on-config-reload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no way to update config on the run with method
config:reload()instead of listen parameters.This patch fixes it, all options support config reload.
Closes #216