fix: #259 The HTTP Authentication Scheme patterns should be case-inse… #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be case-insensitive The `basic` and `bearer` authentication scheme tokens should be considered case-insensitive per [Section 2.1 of RFC 7235](https://datatracker.ietf.org/doc/html/rfc7235#section-2.1).
Author
|
@scaytrase Any chance this could be merged? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into random "None of security schemas did match for …" validation errors. This was being caused by the
League\OpenAPIValidation\PSR7\Validators\SecurityValidator:: AUTH_PATTERN_*patterns, which do not have the case-insensitivity flag (i) set.The
basicandbearerauthentication scheme tokens should be considered case-insensitive per Section 2.1 of RFC 7235. So this PR adds theiflag so that the matching is done in a case-insensitive manner.