Add Jenkinsfile, refactor docs, move iOS-project to ios/ #51
Conversation
| if os.path.exists('iphone'): | ||
| create_module('iphone', 'appc ti build -p ios') | ||
| packages.append('iphone') | ||
| if os.path.exists('ios'): |
There was a problem hiding this comment.
This change is right, but really this file should go away entirely if we're using the appc cli to build now.
There was a problem hiding this comment.
Unfortunatley we cannot at this point, as the appc-cli is not able to package cross-platform modules into one package, so far. I'd love to get rid of all of them. Maybe we could start by removing the platform-specific build.py in ios/.
sgtcoolguy
left a comment
sgtcoolguy
left a comment
There was a problem hiding this comment.
Does this require XCode-9 or something? The iOS build is failing:
10:02:55 [iOS] [INFO] : �� � Project directory: /Users/build/jenkins/workspace/es_appcelerator.https_PR-51-MQQYFVJLFUWQONPXXSIUY56XVREWKQHAILTDFD3BFLX4JDPKT5GQ/ios
10:02:55 [iOS] [INFO] : �� � Module ID: appcelerator.https
10:02:57 [iOS] [ERROR] : �� �[xcode-sim] ** BUILD FAILED **
10:02:57 [iOS] [ERROR] : �� �[xcode-sim] The following build commands failed:
10:02:57 [iOS] [ERROR] : �� �[xcode-sim] CompileC build/appcelerator.https.build/Release-iphonesimulator/appcelerator.https.build/Objects-normal/i386/X509CertificatePinningSecurityManagerProxy.o appcelerator.https/X509CertificatePinningSecurityManagerProxy.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler
10:02:57 [iOS] [ERROR] : �� �[xcode-sim] (1 failure)
| @@ -0,0 +1 @@ | |||
| {"exports":[]} No newline at end of file | |||
There was a problem hiding this comment.
Doesn't this file get generated by the build?
|
|
||
| buildModule { | ||
| // defaults: | ||
| //nodeVersion = '6.11.4' // Must have version set up on Jenkins master before it can be changed |
There was a problem hiding this comment.
FYI, these actually are not the default values used. We default to node 4.7.3, sdk 6.0.3.GA, android 23, build-tools 23.0.3, ndk r12b. See https://github.com/appcelerator/pipeline-library/blob/master/vars/buildModule.groovy#L126-L151
|
Weird, both iOS and Android are failing to build. Android complains it can't find a suitable sdk version (23 is installed, so are google api addons for 23) - I'm guessing it's a CLI bug there? There are no android platforms listed in iOS is failing to compile. I don't know if that's because we need a specific Xcode version or what. |
|
Will check iOS, thx |
|
I'm not sure what's going on with Android, no targets are listed with 6.0.3.GA, so I'm fiddling with combinations of SDKs locally and I'm going to update the defaults used to build modules. Looks like api level 25, Ti SDK 6.2.2.GA, build tools 25.0.3, NDK r12b might work. |
|
@sgtcoolguy Have you tried explicitly setting the Android SDK path? |
|
Waiting for the other PR's to be merged before moving things. |
3 participants
No description provided.