Skip to content

Fix errcheck / gopls nits in main.go #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix errcheck / gopls nits in main.go #4416

wants to merge 1 commit into from

Conversation

bradlarsen
Copy link
Contributor

Description:

This PR fixes 3 nits identified by errcheck and the gopls LSP server:

  • Adds missing error checking around a fallible os.SetEnv call
  • Switches a loop over a call to strings.Split to call the more efficient strings.SplitSeq instead
  • Switches an older-style counting loop to use the newer range-over-int added in Go 1.22 in Feb 2024

These are pedantic nits. The changes should not noticeably affect runtime behavior, but will quiet down editor tools.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@bradlarsen bradlarsen requested a review from a team as a code owner August 22, 2025 22:40
mcastorina
mcastorina approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TIL range int and SplitSeq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bradlarsen @mcastorina