-
Notifications
You must be signed in to change notification settings - Fork 23
refactor: reorganize array expressions in proto #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bcallender
wants to merge
2
commits into
main
Choose a base branch
from
feat/array-agg-proto-organization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
caf97b2 to
dfd5fe4
Compare
020fc46 to
d681ab9
Compare
dfd5fe4 to
ef6efac
Compare
d681ab9 to
0e249d8
Compare
ef6efac to
8c8e108
Compare
0e249d8 to
ca6ddf8
Compare
8c8e108 to
68626fe
Compare
ca6ddf8 to
bfd20e7
Compare
68626fe to
f34a9cb
Compare
23fc3c7 to
cabeaa3
Compare
3647cab to
d38d3ea
Compare
cabeaa3 to
b0db1c3
Compare
YoungVor
approved these changes
Oct 21, 2025
Contributor
YoungVor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, since the array_* pr will test that this is all correct. Just had a few nits
d38d3ea to
04b5e93
Compare
b0db1c3 to
16b4a71
Compare
04b5e93 to
5b1fe28
Compare
16b4a71 to
f3c48b9
Compare
f3c48b9 to
18d41f8
Compare
…lopment - Group all array expressions together with inline documentation - Add comments guiding future array function additions - Preserve existing field numbers for backwards compatibility - No functional changes, pure organization
18d41f8 to
60e8752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Array Functions Organization
This PR reorganizes array expressions in the logical plan proto to improve maintainability:
The following array functions are now properly organized:
This organization makes it easier to find and understand array functions, while providing clear guidance for adding new array functions in the future, laying the ground work for the array operations we will be adding in further downstack PRs.