Skip to content

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 12, 2025

Description

Handle issue described in umbraco/Umbraco-CMS#20457

It have highlighted container with max-width: 420px and the the button in uui-ref-node itself.
However it seems e.g. slots like "actions" should be considered in full width, so it fit within a container size.

image

Perhaps uui-ref-node needs a wrap property/attribute - in case it sometimes need multi-line details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copilot AI review requested due to automatic review settings October 12, 2025 15:56
@github-actions
Copy link

github-actions bot commented Oct 12, 2025

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where long links in uui-ref-node components would overflow their containers. The fix adds CSS properties to properly constrain the width and handle text overflow with ellipsis.

  • Added width constraints and overflow handling to prevent long text from breaking the layout
  • Added a Storybook story demonstrating the fix with an extremely long URL

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/uui-ref-node/lib/uui-ref-node.element.ts Added CSS width constraints and text overflow handling to prevent layout issues
packages/uui-ref-node/lib/uui-ref-node.story.ts Added test case story with a very long URL to demonstrate the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant