-
Couldn't load subscription status.
- Fork 56
Handle long links in uui-ref-node
#1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where long links in uui-ref-node components would overflow their containers. The fix adds CSS properties to properly constrain the width and handle text overflow with ellipsis.
- Added width constraints and overflow handling to prevent long text from breaking the layout
- Added a Storybook story demonstrating the fix with an extremely long URL
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/uui-ref-node/lib/uui-ref-node.element.ts | Added CSS width constraints and text overflow handling to prevent layout issues |
| packages/uui-ref-node/lib/uui-ref-node.story.ts | Added test case story with a very long URL to demonstrate the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|



Description
Handle issue described in umbraco/Umbraco-CMS#20457
It have highlighted container with
max-width: 420pxand the the button inuui-ref-nodeitself.However it seems e.g. slots like "actions" should be considered in full width, so it fit within a container size.
Perhaps
uui-ref-nodeneeds awrapproperty/attribute - in case it sometimes need multi-line details.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist