Support for proper encoding of addresses (don't remove leading 0s from string) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc0Vu
reviewed
Sep 13, 2023
Member
sc0Vu
left a comment
sc0Vu
left a comment
There was a problem hiding this comment.
Thanks for your contribution, I leave some comments. Let me know if you have other questions.
| } | ||
| throw new InvalidArgumentException('The input type didn\'t support.'); | ||
| } | ||
| protected function encodeInput($input, $type = false) |
Member
There was a problem hiding this comment.
Should we submit another PR for this feature?
| switch ($encoding) { | ||
| case 'hex': | ||
| // fixed length hex | ||
| case 'hex_fixed': |
Member
There was a problem hiding this comment.
Nice catch. How about use type instead of hex_fixed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.