Skip to content

Conversation

@Rory-Z
Copy link

@Rory-Z Rory-Z commented Mar 5, 2021

No description provided.

Copy link
Owner

@wei wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not backwards compatible. Perhaps negate the logic?

SOURCE_BRANCH=$2
DESTINATION_REPO=$3
DESTINATION_BRANCH=$4
DESTINATION_FORCE_PUSH=$5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is unused.

Copy link

@rivy rivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should make the PR backwards-compatible.

Copy link

@rivy rivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These above changes should make the PR backwards-compatible.

Rory-Z and others added 2 commits October 2, 2022 17:08
Co-authored-by: Roy Ivy III <rivy.dev@gmail.com>
Co-authored-by: Roy Ivy III <rivy.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants