Skip to content

getting index type #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

getting index type #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ydb/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ def __init__(self, name):
self.index_columns = []
# output only.
self.status = None
self.type = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this field also should be in the constructor


def with_global_index(self):
self._pb.global_index.SetInParent()
Expand All @@ -301,6 +302,12 @@ def to_pb(self):
return self._pb


@enum.unique
class IndexType(enum.IntEnum):
SYNCHRONOUS = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use enum.auto() here

ASYNCHRONOUS = 1


class ReplicationPolicy(object):
def __init__(self):
self._pb = _apis.ydb_table.ReplicationPolicy()
Expand Down Expand Up @@ -1337,6 +1344,10 @@ def async_bulk_upsert(self, table_path, rows, column_types, settings=None):
def _make_index_description(index):
result = TableIndex(index.name).with_index_columns(*tuple(col for col in index.index_columns))
result.status = IndexStatus(index.status)
if index.HasField("global_async_index"):
result.type = IndexType(IndexType.ASYNCHRONOUS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no needs to IndexType(IndexType.ASYNCHRONOUS). IndexType.ASYNCHRONOUS/IndexType.SYNCHRONOUS close enough.

else:
result.type = IndexType(IndexType.SYNCHRONOUS)
return result


Expand Down