Add clang-format check in CI/CD and format all files #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacharle
force-pushed
the
ci-cd-formatting
branch
from
ffc351b to
9a7556e
Compare
cacharle
force-pushed
the
ci-cd-formatting
branch
from
7ddc6a7 to
285b4cf
Compare
Pull Request Test Coverage Report for Build 18599605414Details
💛 - Coveralls |
cacharle
force-pushed
the
ci-cd-formatting
branch
from
285b4cf to
e354989
Compare
cacharle
commented
Oct 17, 2025
Comment on lines
+33
to
+41
| // To avoid the `(std::min)` workaround for when a min macro is defined | ||
| #ifdef min | ||
| #define WINDOWS_MIN min | ||
| #undef min | ||
| #endif | ||
| #ifdef max | ||
| #define WINDOWS_MAX max | ||
| #undef max | ||
| #endif |
There was a problem hiding this comment.
This was initially to fix the formatting being different between clang-format 14 and 20 for the (std::min)(x, y) trick.
I ended up fixing it differently but this "guard" macros seems a bit cleaner than having to remember the (std::min) workaround. Let me know if I should keep it
(Still have to test if it works on Windows tho)
.github/workflows/ci.yml
Outdated
Comment on lines
135
to
140
| - name: format | ||
| if: ${{ startsWith(matrix.os, 'ubuntu-24') }} | ||
| run: | | ||
| clang-format --version | ||
| git ls-files | grep -E '\.(cpp|hpp)' | xargs clang-format --dry-run --Werror | ||
| sudo apt install -y clang-format-20 | ||
| clang-format-20 --version | ||
| git ls-files | grep -E '\.(cpp|hpp)' | xargs clang-format-20 --dry-run --Werror |
There was a problem hiding this comment.
Is running clang-format 20 only on Ubuntu okay?
Not sure how to solve the fact that people might have different versions installed..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatter hasn't been run in a long time so I formatted all the files (with the exact same formatting config as before) and added a check in CI/CD.
I feel like having a pre-commit config to run clang-format before commiting might be handy aswell