-
Notifications
You must be signed in to change notification settings - Fork 759
Add INetMQMonitor interface to enable mocking in tests #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add INetMQMonitor interface to enable mocking in tests #1138
Conversation
Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
@copilot PTAL |
@djangohunt does this look good to you? Happy with the members on the interface? |
…eedback Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please improve the docs as described.
…d periods, use cref, add inheritdoc Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
Done in commit 9c4e6bf. All documentation improvements have been applied as described in the review comments. |
…inheritdoc in NetMQMonitor Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
Co-authored-by: drewnoakes <350947+drewnoakes@users.noreply.github.com>
This PR adds an
INetMQMonitor
interface to allow mocking ofNetMQMonitor
in tests, similar to the existingINetMQSocket
andINetMQPoller
interfaces.Changes Made
Created
INetMQMonitor
interface (src/NetMQ/Monitoring/INetMQMonitor.cs
) containing all public members ofNetMQMonitor
:Endpoint
,IsRunning
,Timeout
AttachToPoller
,DetachFromPoller
,Start
,StartAsync
,Stop
,Dispose
Updated
NetMQMonitor
to implementINetMQMonitor
interface with<inheritdoc />
tags throughout to inherit documentation from the interfaceDeleted
NuGet.Config
file as it only contained the default NuGet.org package source and is no longer neededDocumentation
All XML documentation follows best practices:
<see cref="..." />
when referring to symbolsTesting
Fixes #1137
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.