std.os.windows: eliminate forwarder function in kernel32 #25766
Merged
+77
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
requested changes
Oct 30, 2025
There was a problem hiding this comment.
It would be better to fully delete the functions from kernel32.zig and update any callsites to use the corresponding ntdll functions directly. Having functions in the kernel32 namespace that are actually ntdll functions is confusing more than it is helpful, and making breaking changes to kernel32.zig is fine.
qilme
force-pushed
the
std_os_windows
branch
2 times, most recently
from
60f1571 to
8f09e89
Compare
kernel32.AddVectoredExceptionHandler -> ntdll.RtlAddVectoredExceptionHandler kernel32.RemoveVectoredExceptionHandler -> ntdll.RtlRemoveVectoredExceptionHandler kernel32.ExitProcess -> ntdll.RtlExitUserProcess kernel32.InitializeCriticalSection -> ntdll.RtlInitializeCriticalSection kernel32.EnterCriticalSection -> ntdll.RtlEnterCriticalSection kernel32.LeaveCriticalSection -> ntdll.RtlLeaveCriticalSection kernel32.DeleteCriticalSection -> ntdll.RtlDeleteCriticalSection kernel32.TryAcquireSRWLockExclusive -> ntdll.RtlTryAcquireSRWLockExclusive kernel32.AcquireSRWLockExclusive -> ntdll.RtlAcquireSRWLockExclusive kernel32.ReleaseSRWLockExclusive -> ntdll.RtlReleaseSRWLockExclusive kernel32.WakeConditionVariable -> ntdll.RtlWakeConditionVariable kernel32.WakeAllConditionVariable -> ntdll.RtlWakeAllConditionVariable kernel32.HeapReAlloc -> ntdll.RtlReAllocateHeap kernel32.HeapAlloc -> ntdll.RtlAllocateHeap kernel32.HeapFree -> ntdll.RtlFreeHeap
squeek502
reviewed
Oct 30, 2025
…`HeapFree` in kernel32
squeek502
reviewed
Oct 31, 2025
squeek502
reviewed
Oct 31, 2025
|
Sorry for i accidentally clicked update branch manually instead of letting the auto-merge run. |
|
No worries! |
|
Nice change, thank you! |
jedisct1
added a commit
to jedisct1/zig
that referenced
this pull request
Nov 1, 2025
* master: Implement threaded BLAKE3 (ziglang#25587) std: Skip element comparisons if `mem.order` args point to same memory std.Target: bump vulkan max version to 1.4.331 std.Target: bump opencl/nvcl max version to 3.0.19 std.Target: bump cuda max version to 13.0.2 std.Target: bump amdhsa max version to 7.1.0 std.Target: bump wasi max version to 0.3.0 std.Target: bump dragonfly max version to 6.4.2 std.Target: bump linux max version to 6.17 std.Target: bump fuchsia max version to 28.0.0 std.Target: bump contiki max version to 5.1.0 test: remove some unsupported x86_64 darwin targets from llvm_targets std.os.windows: eliminate forwarder function in kernel32 (ziglang#25766)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1840