Tweak UnreadCountBadge to prepare for design updates; use it in topic list too
#1959
+67
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
maintainer review
rajveermalviya
approved these changes
Nov 4, 2025
rajveermalviya
added
integration review
|
Looks fine to me, thanks! |
The "Channels" page and "Inbox" page both have updated designs in Figma, which we should follow. This commit matches the badges on the "Channels" page to that new design. There's more work to match the badges on the "Inbox" page, but now that work is defined crisply in a TODO: // TODO support the "kind=quantity" variant, update dartdoc Related: zulip#1406 Related: zulip#1527
The private widget, following the Figma, made the badge a bit more compact, with 1px less padding on each side, and a font size smaller by 1 (but with the same line height). That was helpful for keeping the rows at uniform height regardless of unreads (without text scaling anyway)...but I've accomplished that by adding a minimum row height (40), in the previous commit.
gnprice
force-pushed
the
pr-unread-counter-tweaks
branch
from
4ffeb17 to
89b85dc
Compare
|
Thanks for updating these! LGTM; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes our
UnreadCountBadgewidget match the Figma for the badges on the "Channels" page, forand closer to matching the badges on the "Inbox" page (but not yet), for
(Also, reuse the widget in the topic-list page for consistency, which makes small differences from the Figma, where the rows are too compact anyway; we like to give touch targets a minimum height of 40, for accessibility, and I've done that here.)
Related: #1406
Related: #1527
cc @alya