Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,10 @@
"@loginMethodDivider": {
"description": "Text on the divider between the username/password form and the third-party login options. Uppercase (for languages with letter case)."
},
"loginMethodDividerSemanticLabel": "Log-in alternatives",
"@loginMethodDividerSemanticLabel": {
"description": "Semantic label for OrDivider in login page."
},
"signInWithFoo": "Sign in with {method}",
"@signInWithFoo": {
"description": "Button to use {method} to sign in to the app.",
Expand Down
6 changes: 6 additions & 0 deletions lib/generated/l10n/zulip_localizations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,12 @@ abstract class ZulipLocalizations {
/// **'OR'**
String get loginMethodDivider;

/// Semantic label for OrDivider in login page.
///
/// In en, this message translates to:
/// **'Log-in alternatives'**
String get loginMethodDividerSemanticLabel;

/// Button to use {method} to sign in to the app.
///
/// In en, this message translates to:
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_ar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_de.dart
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,9 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
@override
String get loginMethodDivider => 'ODER';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Anmelden mit $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_el.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_en.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_es.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_fr.dart
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,9 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_he.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_hu.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsHu extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_it.dart
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,9 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
@override
String get loginMethodDivider => 'O';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Accedi con $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_ja.dart
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,9 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
@override
String get loginMethodDivider => 'または';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return '$methodでログイン';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_nb.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_pl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
@override
String get loginMethodDivider => 'LUB';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Logowanie z $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_ru.dart
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
@override
String get loginMethodDivider => 'ИЛИ';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Войти с помощью $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_sk.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
@override
String get loginMethodDivider => 'alebo';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Prihlásiť sa pomocou $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_sl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@ class ZulipLocalizationsSl extends ZulipLocalizations {
@override
String get loginMethodDivider => 'ALI';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Prijava z $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_uk.dart
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,9 @@ class ZulipLocalizationsUk extends ZulipLocalizations {
@override
String get loginMethodDivider => 'АБО';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Увійти з $method';
Expand Down
3 changes: 3 additions & 0 deletions lib/generated/l10n/zulip_localizations_zh.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,9 @@ class ZulipLocalizationsZh extends ZulipLocalizations {
@override
String get loginMethodDivider => 'OR';

@override
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';

@override
String signInWithFoo(String method) {
return 'Sign in with $method';
Expand Down
27 changes: 15 additions & 12 deletions lib/widgets/login.dart
Original file line number Diff line number Diff line change
Expand Up @@ -677,17 +677,20 @@ class OrDivider extends StatelessWidget {

return Padding(
padding: const EdgeInsets.symmetric(vertical: 10),
child: Row(crossAxisAlignment: CrossAxisAlignment.center, children: [
divider,
Padding(
padding: const EdgeInsets.symmetric(horizontal: 5),
child: Text(zulipLocalizations.loginMethodDivider,
textAlign: TextAlign.center,
style: TextStyle(
color: designVariables.loginOrDividerText,
height: 1.5,
).merge(weightVariableTextStyle(context, wght: 600)))),
divider,
]));
child: Semantics(
excludeSemantics: true,
label: zulipLocalizations.loginMethodDividerSemanticLabel,
child: Row(crossAxisAlignment: CrossAxisAlignment.center, children: [
divider,
Padding(
padding: const EdgeInsets.symmetric(horizontal: 5),
child: Text(zulipLocalizations.loginMethodDivider,
textAlign: TextAlign.center,
style: TextStyle(
color: designVariables.loginOrDividerText,
height: 1.5,
).merge(weightVariableTextStyle(context, wght: 600)))),
divider,
])));
}
}